Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL for HyP3 sample notebook #1113

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

hjkristenson
Copy link
Contributor

@hjkristenson hjkristenson commented Nov 2, 2023

Description of proposed changes

The link to the smallbaselineApp_hyp3.ipynb tutorial was broken in https://github.com/insarlab/MintPy/blob/main/docs/dir_structure.md. It looks like that notebook was moved into a workflows subdirectory. This PR updates the URL to the current notebook location.

Reminders

  • Fix #xxxx
  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Copy link

welcome bot commented Nov 2, 2023

💖 Thanks for opening this pull request! Please check out our contributing guidelines. 💖
Keep in mind that all new features should be documented. It helps to write the comments next to the code or below your functions describing all arguments, and return types before writing the code. This will help you think about your code design and usually results in better code.

@yunjunz yunjunz self-requested a review November 3, 2023 03:20
Copy link
Member

@yunjunz yunjunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yunjunz
Copy link
Member

yunjunz commented Nov 3, 2023

Thank you @hjkristenson for the fix. I will merge it right away.

When you get a chance, could you take a look at #1004 also?

@yunjunz yunjunz merged commit 427e4ec into insarlab:main Nov 3, 2023
8 checks passed
Copy link

welcome bot commented Nov 3, 2023

🎉 🎉 🎉 Congrats on merging your first pull request! We here at behaviorbot are proud of you! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants