ruby 3.3 support #97
Merged
ruby 3.3 support #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vasfed
commented
May 9, 2024
Vasfed
commented
- Test on ruby 3.3
- Tempfile#size patch was broken on ruby 3.3, also fix rubocop
ngoral
reviewed
May 9, 2024
| dstio = case path_or_file | ||
| when String then File.new(path_or_file, "wb+") | ||
| when IO, Tempfile then path_or_file | ||
| end | ||
| buffer = "" | ||
| buffer = +"" |
There was a problem hiding this comment.
нет, в патче под винду ниже, оно всегда возвращало 0 на 3.3
There was a problem hiding this comment.
Я что-то даже не обратила внимание) Круть!
ngoral
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.