Greg/250/chain observer #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
force-pushed
the
jpraynaud/250-chain-observer
branch
from
9981f96 to
f44dfc6
Compare
ghubertpalo
force-pushed
the
greg/250/chain-observer
branch
from
04eba8b to
dae68cb
Compare
ghubertpalo
commented
Jun 22, 2022
jpraynaud
reviewed
Jun 22, 2022
Comment on lines
59
to
60
| .arg("--cardano-mode") | ||
| .arg("--testnet-magic 42") |
There was a problem hiding this comment.
Maybe we need to configure these options:
--cardano-modeonly necessary on thedevnet--testnet-magic ${TESTNET_MAGIC_ID}only necessary on thedevnetand thetestnet(with a different${TESTNET_MAGIC_ID}for each network)--mainnetused instead on themainnet
These configuration options will be also needed in the launch_stake_distribution cli call
jpraynaud
force-pushed
the
jpraynaud/250-chain-observer
branch
from
f44dfc6 to
bdbdabf
Compare
ghubertpalo
force-pushed
the
greg/250/chain-observer
branch
from
1ff4525 to
c451a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CLI runner with a float String -> u64 parser.