chore(client-lib): deprecate current aggregator client and related builder functions #2738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/2640/deprecate_client_lib_aggregator_client
branch
from
c1e7d29 to
e40954f
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
…or_client` They will be removed soon in order to allow reworking the aggregator client layer. Note: no alternative will be added.
As it will be entirely reworked to use the shared `mithril-aggregator-client` crate. Note: this depreciation generate more than 360 warnings, as such it was chosen to add globals `allow(deprecated)` instead of adding them everywhere.
* mithril-client from `0.12.32` to `0.12.33`
Alenar
force-pushed
the
djo/2640/deprecate_client_lib_aggregator_client
branch
from
e40954f to
d60bb5e
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR deprecate several parts of the
mithril-clientlibrary in order to allow.The following functions or modules are deprecated :
ClientBuider::with_aggregator_client: with the upcoming refactor, we won't allow anymore users to entirely replace the communication mechanisms with the aggregatorClientBuider::new: it whole purpose was to be used conjointly withwith_aggregator_clientaggregator_clientmodule as it will be entirely reworked to use themithril-aggregator-clientlibraryImportant
Deprecating the
aggregator_clientmodule generated more than 350 warnings in the client library, as such I decided to use globalallow(deprecated)instead of putting those on every offenders.There were only one previously existing
deprecatedon the crate but given the implication of this choice I added some TODOs to remind that the globalallow(deprecated)must be removed when the refactor will be finished.Pre-submit checklist
Issue(s)
Relates to #2640