-
Notifications
You must be signed in to change notification settings - Fork 51
feat: integrate Haskell DMQ network #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9b4e6b2 to
8743123
Compare
ac77483 to
a9d7064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates Haskell DMQ (Distributed Message Queue) network support with Mithril nodes, enabling communication through DMQ in addition to existing methods. The changes introduce a dedicated DmqNetwork type to handle DMQ-specific networking while maintaining separation from the existing CardanoNetwork infrastructure.
Key changes include:
- Created new
DmqNetworkmodel with separate magic IDs for DMQ communication - Updated configuration to support both Cardano and DMQ network magic numbers
- Modified devnet infrastructure to support running DMQ nodes alongside Cardano nodes
Reviewed Changes
Copilot reviewed 44 out of 46 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/mithril-dmq/src/model/network.rs | New DMQ network model implementation |
| mithril-signer/src/configuration.rs | Added DMQ network configuration support |
| mithril-aggregator/src/configuration.rs | Added DMQ network configuration support |
| mithril-test-lab/mithril-devnet/ | Extended devnet to support DMQ nodes |
| mithril-relay/src/ | Updated relay components to use DmqNetwork instead of CardanoNetwork |
| internal/mithril-dmq/src/model/builder.rs | Modified DMQ message structure for operational certificates |
Comments suppressed due to low confidence (1)
internal/mithril-dmq/src/model/network.rs:1
- Magic numbers are used with TODO comments indicating they need updating. These placeholder values should be replaced with actual DMQ network magic IDs before production use.
use serde::{Deserialize, Serialize};
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mithril-test-lab/mithril-devnet/mkfiles/mkfiles-topology-dmq.sh
Outdated
Show resolved
Hide resolved
a9d7064 to
c55c100
Compare
c55c100 to
6eda08f
Compare
ded0701 to
a75b6b2
Compare
2a38b2a to
64b0af9
Compare
Alenar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Among (cardano,mithril,dmq).
64b0af9 to
ac8fca6
Compare
By running 'cargo update [email protected]'.
ac8fca6 to
774db05
Compare
* mithril-dmq from `0.1.12` to `0.1.13` * mithril-aggregator from `0.7.89` to `0.7.90` * mithril-common from `0.6.24` to `0.6.25` * mithril-relay from `0.1.52` to `0.1.53` * mithril-signer from `0.2.272` to `0.2.273` * mithril-end-to-end from `0.4.106` to `0.4.107` * mithril-infra/assets/infra.version from `0.4.12` to `0.4.13` * mithril-test-lab/mithril-devnet/VERSION from `0.4.15` to `0.4.16`
774db05 to
2c9cd08
Compare
Content
This PR includes the integration of the Haskell DMQ node with the Mithril nodes:
DmqNetworkto represent the DMQ network (instead of using theCardanoNetwork)DmqMsgdevnetto support an attached DMQ networkPre-submit checklist
Issue(s)
Relates to #2674