Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 30, 2025

Content

This PR includes the integration of the Haskell DMQ node with the Mithril nodes:

  • Created a DmqNetwork to represent the DMQ network (instead of using the CardanoNetwork)
  • Implemented modifications in the structure of the DmqMsg
  • Adapted the devnet to support an attached DMQ network
  • Adapted the e2e test to support testing against the Haskell DMQ node

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • No new TODOs introduced

Issue(s)

Relates to #2674

@jpraynaud jpraynaud self-assigned this Sep 30, 2025
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Test Results

    4 files  ± 0    168 suites  ±0   24m 23s ⏱️ -9s
2 264 tests + 3  2 264 ✅ + 3  0 💤 ±0  0 ❌ ±0 
6 999 runs  +12  6 999 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 2c9cd08. ± Comparison against base commit bbb0c06.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch 3 times, most recently from 9b4e6b2 to 8743123 Compare October 7, 2025 17:03
@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch 12 times, most recently from ac77483 to a9d7064 Compare October 14, 2025 13:25
@jpraynaud jpraynaud changed the title feat: integrate real DMQ network in the devnet and e2e tests feat: integrate Haskell DMQ network in the devnet and e2e tests Oct 14, 2025
@jpraynaud jpraynaud changed the title feat: integrate Haskell DMQ network in the devnet and e2e tests feat: integrate Haskell DMQ network Oct 14, 2025
@jpraynaud jpraynaud requested a review from Copilot October 14, 2025 13:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates Haskell DMQ (Distributed Message Queue) network support with Mithril nodes, enabling communication through DMQ in addition to existing methods. The changes introduce a dedicated DmqNetwork type to handle DMQ-specific networking while maintaining separation from the existing CardanoNetwork infrastructure.

Key changes include:

  • Created new DmqNetwork model with separate magic IDs for DMQ communication
  • Updated configuration to support both Cardano and DMQ network magic numbers
  • Modified devnet infrastructure to support running DMQ nodes alongside Cardano nodes

Reviewed Changes

Copilot reviewed 44 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/mithril-dmq/src/model/network.rs New DMQ network model implementation
mithril-signer/src/configuration.rs Added DMQ network configuration support
mithril-aggregator/src/configuration.rs Added DMQ network configuration support
mithril-test-lab/mithril-devnet/ Extended devnet to support DMQ nodes
mithril-relay/src/ Updated relay components to use DmqNetwork instead of CardanoNetwork
internal/mithril-dmq/src/model/builder.rs Modified DMQ message structure for operational certificates
Comments suppressed due to low confidence (1)

internal/mithril-dmq/src/model/network.rs:1

  • Magic numbers are used with TODO comments indicating they need updating. These placeholder values should be replaced with actual DMQ network magic IDs before production use.
use serde::{Deserialize, Serialize};

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch from a9d7064 to c55c100 Compare October 14, 2025 14:14
@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch from c55c100 to 6eda08f Compare October 14, 2025 14:21
@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch from ded0701 to a75b6b2 Compare October 15, 2025 13:35
@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch 2 times, most recently from 2a38b2a to 64b0af9 Compare October 21, 2025 07:49
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch from 64b0af9 to ac8fca6 Compare October 22, 2025 09:05
@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch from ac8fca6 to 774db05 Compare October 22, 2025 12:42
* mithril-dmq from `0.1.12` to `0.1.13`
* mithril-aggregator from `0.7.89` to `0.7.90`
* mithril-common from `0.6.24` to `0.6.25`
* mithril-relay from `0.1.52` to `0.1.53`
* mithril-signer from `0.2.272` to `0.2.273`
* mithril-end-to-end from `0.4.106` to `0.4.107`
* mithril-infra/assets/infra.version from `0.4.12` to `0.4.13`
* mithril-test-lab/mithril-devnet/VERSION from `0.4.15` to `0.4.16`
@jpraynaud jpraynaud force-pushed the jpraynaud/2674-dmq-devnet-e2e branch from 774db05 to 2c9cd08 Compare October 22, 2025 12:46
@jpraynaud jpraynaud marked this pull request as ready for review October 22, 2025 12:59
@jpraynaud jpraynaud merged commit a1eecb8 into main Oct 22, 2025
42 of 47 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2674-dmq-devnet-e2e branch October 22, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants