Skip to content

phase 0 : prepare decentralization parameters #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2025
Merged

phase 0 : prepare decentralization parameters #2694

merged 4 commits into from
Sep 19, 2025

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Sep 16, 2025 •
edited
Loading

Content

This PR includes modification to the /epoch-settings endpoint of the Aggregator and its call in the Signer :

  • the removal of next_cardano_transaction_config attribute of EpochSettingsMessage , which was not used by the mithril-signer
  • ensure the retrocompatibilty of the signer with next_cardano_transaction_config removed from
    EpochSettingsMessage
    -increment openapi.yaml version to 0.1.52
  • remove all unused binding of next_cardano_transaction_config in the mithril-signer

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2691

@github-actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

Test Results

    4 files  ±0    164 suites  ±0   22m 43s ⏱️ -59s
2 181 tests +1  2 181 ✅ +1  0 💤 ±0  0 ❌ ±0 
6 706 runs  +4  6 706 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit 2e1ceb7. ± Comparison against base commit d1a61c4.

♻️ This comment has been updated with latest results.

@turmelclem turmelclem force-pushed the ctl/2691-prepare-decentralization-parameters branch from 4193994 to 7b4a8ba Compare September 16, 2025 12:18
@turmelclem turmelclem force-pushed the ctl/2691-prepare-decentralization-parameters branch 2 times, most recently from 668d806 to d4ee983 Compare September 17, 2025 13:27
@turmelclem turmelclem force-pushed the ctl/2691-prepare-decentralization-parameters branch from d4ee983 to 06c5a98 Compare September 18, 2025 07:53
jpraynaud
jpraynaud approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@turmelclem turmelclem self-assigned this Sep 18, 2025
@turmelclem turmelclem force-pushed the ctl/2691-prepare-decentralization-parameters branch from 14d7952 to c9a9f4a Compare September 18, 2025 14:32
@turmelclem turmelclem marked this pull request as ready for review September 18, 2025 15:19
@turmelclem turmelclem force-pushed the ctl/2691-prepare-decentralization-parameters branch from c9a9f4a to c5cdc9c Compare September 18, 2025 15:23
Clément Turmel added 4 commits September 18, 2025 17:37
@turmelclem
refactor(aggregator): removing unused next_cardano_transactions_signi…
449b848 
…ng_config
@turmelclem
refactor(common, aggregator, signer): removing next cardano transacti…
dc47ba3 
…on config from signer and aggregator
@turmelclem
chore: update changelog
a546973
@turmelclem
chore: upgrade crate versions
2e1ceb7 
* mithril-aggregator from `0.7.84` to `0.7.85`
* mithril-common from `0.6.17` to `0.6.18`
* mithril-signer from `0.2.268` to `0.2.269`
* mithril-aggregator-fake from `0.4.13` to `0.4.14`
@turmelclem turmelclem force-pushed the ctl/2691-prepare-decentralization-parameters branch 2 times, most recently from c1aaf17 to 2e1ceb7 Compare September 18, 2025 15:58
@turmelclem turmelclem merged commit 27753f4 into main Sep 19, 2025
57 of 71 checks passed
@turmelclem turmelclem deleted the ctl/2691-prepare-decentralization-parameters branch September 19, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@turmelclem turmelclem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decentralization of configuration parameters - Phase 0

3 participants

@turmelclem @jpraynaud