Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 3, 2025

Content

This PR includes the rollback of the binary encoding for the single signature to the already used JSON hex encoding.
This feature is not mature enough at this time, and releasing it with the next distribution would not allow to evolve this encoding without a Mithril era.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2625

The binary encoding will be activated in a future distribution.
* mithril-common from `0.6.15` to `0.6.16`
@jpraynaud jpraynaud self-assigned this Sep 3, 2025
@github-actions
Copy link

github-actions bot commented Sep 3, 2025

Test Results

    4 files  ±0    164 suites  ±0   24m 1s ⏱️ +13s
2 181 tests ±0  2 181 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 706 runs  ±0  6 706 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4671b53. ± Comparison against base commit 9d9e963.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts the binary encoding for single signatures back to JSON hex encoding, as the binary encoding feature is not yet mature enough for production release. The rollback ensures that the encoding can evolve without requiring a Mithril era change.

  • Moved SingleSignature from bytes_hex_codec to json_hex_codec implementation
  • Updated crate version from 0.6.15 to 0.6.16

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
mithril-common/src/crypto_helper/types/wrappers.rs Reverted SingleSignature encoding from binary to JSON hex
mithril-common/Cargo.toml Bumped version to 0.6.16

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud merged commit af33531 into main Sep 4, 2025
41 of 43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2625-rollback-binary-encoding-single-signature branch September 4, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants