Skip to content

Document immutables folder discovery is recursive #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

Document immutables folder discovery is recursive #2656

merged 3 commits into from
Jul 29, 2025

Conversation

@turmelclem
Copy link
Collaborator

@turmelclem turmelclem commented Jul 28, 2025 •
edited
Loading

Content

Document and test the recursive folder discovery behavior in mithril-cardano-node-internal-database and mithril library

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2621

@turmelclem turmelclem self-assigned this Jul 28, 2025
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Test Results

    4 files  ± 0    154 suites  ±0   22m 19s ⏱️ - 1m 9s
2 121 tests + 3  2 121 ✅ + 3  0 💤 ±0  0 ❌ ±0 
6 478 runs  +12  6 478 ✅ +12  0 💤 ±0  0 ❌ ±0 

Results for commit 7d9b465. ± Comparison against base commit 78f6fcd.

♻️ This comment has been updated with latest results.

@turmelclem turmelclem temporarily deployed to testing-preview July 28, 2025 10:28 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2621-document-immutable-folder-discovery-is-recursive branch 2 times, most recently from d897171 to 3b7dce4 Compare July 28, 2025 13:17
@turmelclem turmelclem temporarily deployed to testing-preview July 28, 2025 13:27 — with GitHub Actions Inactive
@turmelclem turmelclem force-pushed the ctl/2621-document-immutable-folder-discovery-is-recursive branch from 3b7dce4 to 5222486 Compare July 28, 2025 15:14
@turmelclem turmelclem temporarily deployed to testing-preview July 28, 2025 15:25 — with GitHub Actions Inactive
@turmelclem turmelclem marked this pull request as ready for review July 29, 2025 07:23
@turmelclem turmelclem requested review from Alenar and dlachaume July 29, 2025 07:23
Alenar
Alenar approved these changes Jul 29, 2025
View reviewed changes
@turmelclem turmelclem force-pushed the ctl/2621-document-immutable-folder-discovery-is-recursive branch from 5222486 to 4489754 Compare July 29, 2025 09:05
Clément Turmel added 3 commits July 29, 2025 11:12
@turmelclem turmelclem force-pushed the ctl/2621-document-immutable-folder-discovery-is-recursive branch from 4489754 to 7d9b465 Compare July 29, 2025 09:13
@turmelclem turmelclem temporarily deployed to testing-preview July 29, 2025 10:14 — with GitHub Actions Inactive
@turmelclem turmelclem merged commit b790062 into main Jul 29, 2025
70 of 72 checks passed
@turmelclem turmelclem deleted the ctl/2621-document-immutable-folder-discovery-is-recursive branch July 29, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

+1 more reviewer

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@turmelclem turmelclem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document that immutable folder discovery is recursive

4 participants

@turmelclem @Alenar @dlachaume