Skip to content

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jun 27, 2025

Content

This PR uploads Chrome console and driver logs, and Firefox driver logs, when WASM headless tests fail in the test-mithril-client-wasm step of the Mithril Client multi-platform test workflow.
Note: Firefox WebDriver does not currently support retrieving browser console logs via get_log('browser').

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Issue(s)

Closes #2579

@dlachaume dlachaume self-assigned this Jun 27, 2025
@github-actions
Copy link

Test Results

    3 files  ±0    102 suites  ±0   16m 4s ⏱️ -32s
2 048 tests ±0  2 048 ✅ ±0  0 💤 ±0  0 ❌ ±0 
4 229 runs  ±0  4 229 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e286e56. ± Comparison against base commit 63bc902.

@dlachaume dlachaume temporarily deployed to testing-preview June 27, 2025 15:26 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review June 27, 2025 15:32
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@turmelclem turmelclem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 772e6c3 into main Jun 30, 2025
48 of 58 checks passed
@dlachaume dlachaume deleted the dlachaume/2579/save-upload-wasm-tests-console-logs branch June 30, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create and store artifacts for the headless tests in the client CI workflow

5 participants