Skip to content

Move store adapters to Mithril Common #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2022
Merged

Move store adapters to Mithril Common #259

merged 4 commits into from
Jun 13, 2022

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 13, 2022 •
edited
Loading

Preliminary step:

  • Move store/adapter from mithril-aggregator to mithril-common
  • Move store/stake_store.rs from mithril-aggregator to mithril-common

Relates to #251

@github-actions
Copy link

github-actions bot commented Jun 13, 2022 •
edited
Loading

Unit Test Results

199 tests  ±0   199 ✔️ ±0   7m 6s ⏱️ -13s
  14 suites ±0       0 💤 ±0 
    5 files   ±0       0 ❌ ±0 

Results for commit fa5552a. ± Comparison against base commit ed8b33b.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud requested review from Alenar and ghubertpalo and removed request for Alenar June 13, 2022 14:46
Alenar
Alenar requested changes Jun 13, 2022
View reviewed changes
@jpraynaud jpraynaud requested a review from Alenar June 13, 2022 16:26
Alenar
Alenar approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit d4ad4b7 into main Jun 13, 2022
@jpraynaud jpraynaud deleted the jpraynaud/251-common-store-adapter branch June 13, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpraynaud @Alenar