Skip to content

Makes ImmutableFile public #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2022
Merged

Makes ImmutableFile public #228

merged 2 commits into from
Jun 1, 2022

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented May 31, 2022

To allow easy listing of the completed immutables for the futur "beacon observer".

@Alenar Alenar requested review from ghubertpalo and jpraynaud May 31, 2022 14:18
@Alenar Alenar force-pushed the djo/immutable_files_helpers branch from 2f96f91 to fd77ae4 Compare May 31, 2022 14:19
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

Unit Test Results

    5 files  ±0    14 suites  ±0   2m 14s ⏱️ -3s
166 tests +1  166 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 47f14b4. ± Comparison against base commit 97ededa.

This pull request removes 3 and adds 4 tests. Note that renamed tests count towards both. 
digesters::immutable_digester::tests ‑ list_immutable_file_should_skip_last_number
digesters::immutable_digester::tests ‑ list_immutable_file_should_works_in_a_empty_folder
src/digesters/digester.rs - digesters::digester ‑ Digester (line 29)

digesters::immutable_digester::tests ‑ reports_progress_when_total_lower_than_20
digesters::immutable_file::tests ‑ list_immutable_file_should_skip_last_number
digesters::immutable_file::tests ‑ list_immutable_file_should_works_in_a_empty_folder
src/digesters/digester.rs - digesters::digester ‑ Digester (line 30)

♻️ This comment has been updated with latest results.

@Alenar
Makes ImmutableFile public
7ed9edb 
to allow easy listing of the completed immutables for the futur "beacon
observer"
@Alenar Alenar force-pushed the djo/immutable_files_helpers branch from fd77ae4 to 7ed9edb Compare May 31, 2022 15:04
ghubertpalo
ghubertpalo suggested changes May 31, 2022
View reviewed changes
@Alenar Alenar force-pushed the djo/immutable_files_helpers branch from 45afb79 to 47f14b4 Compare May 31, 2022 17:17
@Alenar Alenar requested a review from ghubertpalo May 31, 2022 17:19
jpraynaud
jpraynaud approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit 5f3d001 into main Jun 1, 2022
@Alenar Alenar deleted the djo/immutable_files_helpers branch June 1, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

+1 more reviewer

@ghubertpalo ghubertpalo ghubertpalo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Alenar @jpraynaud @ghubertpalo