Fix: URL for snapshot location is wrong #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
May 31, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
I had something different in mind, so that we would still get a URL pointing at the aggregator but resolvable. This makes the client independent from google storage, which makes it possible to re-privatise the google bucket. WDYT?
Member
Author
|
We will address the resolvable urls in issue #232 and use this PR only for fixing the current misconfiguration |
ghubertpalo
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing config environment vars which caused the loading of development configuration in production
Closes #223