Feat: implement `CardanoDatabase` artifact routes #2187

jpraynaud · 2024-12-18T17:32:54Z

Content

This PR includes the implementation of the artifact routes for the CardanoDatabase signed entity type.

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- No clippy warnings in the CI
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested

Issue(s)

Closes #2152

…ePart'

…pshotMessage' and 'CardanoDatabaseSnapshotListItemMessage'

github-actions · 2024-12-18T17:41:12Z

Test Results

4 files ± 0 52 suites ±0 10m 35s ⏱️ +16s
1 460 tests +12 1 460 ✅ +12 0 💤 ±0 0 ❌ ±0
1 716 runs +12 1 716 ✅ +12 0 💤 ±0 0 ❌ ±0

Results for commit 57efde6. ± Comparison against base commit 6cb9d30.

♻️ This comment has been updated with latest results.

…ntity service

… option

dlachaume

LGTM 👍

mithril-common/src/messages/cardano_database_list.rs

mithril-aggregator/src/services/message.rs

mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs

mithril-test-lab/mithril-end-to-end/src/end_to_end_spec.rs

sfauvel

LGTM
Some remarks to simplify reading the code

mithril-aggregator/src/artifact_builder/cardano_database.rs

mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs

mithril-aggregator/src/services/message.rs

mithril-aggregator/src/services/signed_entity.rs

mithril-test-lab/mithril-end-to-end/src/assertions/check.rs

Alenar

LGTM, I wonder if the new parameter could be avoided.

mithril-aggregator/src/http_server/routes/artifact_routes/snapshot.rs

mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs

mithril-common/src/messages/cardano_database_list.rs

mithril-common/src/messages/cardano_database.rs

mithril-common/src/messages/cardano_database_list.rs

mithril-common/src/messages/cardano_database.rs

mithril-common/src/messages/message_parts/signed_entity_type_message.rs

mithril-aggregator/src/configuration.rs

mithril-aggregator/src/http_server/routes/artifact_routes/cardano_database.rs

openapi.yaml

…d entity service

… module of HTTP server

… database messages

…ages

…ng is enabled in the HTTP server

* mithril-aggregator from '0.6.4' to '0.6.5' * mithril-common from '0.4.97' to '0.4.98' * mithril-end-to-end from '0.4.55' to '0.4.56' * openapi.yaml from '0.1.38' to '0.1.39'

jpraynaud added 5 commits December 18, 2024 12:41

chore: rename 'digest' to 'digests' in 'ArtifactsLocations' entities

50a2d8a

feat: add 'CardanoDatabaseSnapshotMessage' message

cc0ae52

feat: add 'CardanoDatabaseSnapshotListMessage' message

4902ce4

chore: make artifact location types public

379a54f

feat: add conversion from 'CardanoDBBeacon' to 'CardanoDBBeaconMessag…

5972c29

…ePart'

jpraynaud self-assigned this Dec 18, 2024

feat: add conversion from 'SignedEntityRecord' to 'CardanoDatabaseSna…

07825c7

…pshotMessage' and 'CardanoDatabaseSnapshotListItemMessage'

jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from fc72970 to a91d12f Compare December 18, 2024 17:41

jpraynaud added 2 commits December 18, 2024 18:43

feat: compute Cardano database messages in message service

a39e76d

feat: add list and detail retrieval for 'CardanoDatabase' in signed e…

934fce7

…ntity service

jpraynaud temporarily deployed to testing-preview December 18, 2024 17:54 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-sanchonet December 18, 2024 17:54 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-preview December 19, 2024 08:49 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-sanchonet December 19, 2024 08:49 — with GitHub Actions Inactive

jpraynaud added 2 commits December 19, 2024 13:11

feat: update OpenAPI for 'CardanoDatabase' artifact routes

8928393

feat: implement 'CardanoDatabase' artifact routes

84f516e

jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from a91d12f to 0ae9c39 Compare December 19, 2024 12:12

jpraynaud added 3 commits December 19, 2024 13:20

feat: check 'CardanoDatabse' artifacts production in the e2e test

99f7312

chore: remove unused 'URL_SNAPSHOT_MANIFEST' aggregator configuration…

06cf6bf

… option

feat: add an option to allow http directory serving in aggregator

9eded88

jpraynaud temporarily deployed to testing-preview December 19, 2024 12:25 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-sanchonet December 19, 2024 12:25 — with GitHub Actions Inactive

jpraynaud marked this pull request as ready for review December 19, 2024 12:31

jpraynaud requested review from Alenar, dlachaume and sfauvel December 19, 2024 12:31

dlachaume approved these changes Dec 19, 2024

View reviewed changes

sfauvel approved these changes Dec 19, 2024

View reviewed changes

Alenar approved these changes Dec 19, 2024

View reviewed changes

jpraynaud added 8 commits December 20, 2024 13:12

chore: apply style review comments

0fbd0e6

refactor: better implementation of signed entities retrieval in signe…

7b182e9

…d entity service

refactor: create 'add_content_disposition_header' function in 'reply'…

3570580

… module of HTTP server

refactor: remove usage of 'CardanoDbBeaconMessagePart' in the Cardano…

c90c39c

… database messages

refactor: use latest golden tests structure for Cardano database mess…

c8e1938

…ages

chore: fix typos in golden tests of messages

0e9a254

refactor: enhance message service tests

6971f6c

refactor: make configuration automatically compute if directory servi…

92470a7

…ng is enabled in the HTTP server

jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from 0ae9c39 to b4093cc Compare December 20, 2024 12:14

jpraynaud temporarily deployed to testing-preview December 20, 2024 13:22 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-sanchonet December 20, 2024 13:22 — with GitHub Actions Inactive

jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch 2 times, most recently from d4792e2 to dc45eac Compare December 20, 2024 14:46

jpraynaud added 3 commits December 20, 2024 15:57

refactor: make e2e tests assertions more readable

6132903

docs: update CHANGELOG

f369ef3

chore: upgrade crates versions and openapi.yaml version

57efde6

* mithril-aggregator from '0.6.4' to '0.6.5' * mithril-common from '0.4.97' to '0.4.98' * mithril-end-to-end from '0.4.55' to '0.4.56' * openapi.yaml from '0.1.38' to '0.1.39'

jpraynaud force-pushed the jpraynaud/2152-cardano-db-artifact-routes branch from dc45eac to 57efde6 Compare December 20, 2024 14:57

jpraynaud temporarily deployed to testing-preview December 20, 2024 15:19 — with GitHub Actions Inactive

jpraynaud temporarily deployed to testing-sanchonet December 20, 2024 15:19 — with GitHub Actions Inactive

jpraynaud merged commit d3e21fb into main Dec 20, 2024
53 checks passed

jpraynaud deleted the jpraynaud/2152-cardano-db-artifact-routes branch December 20, 2024 15:29

Feat: implement CardanoDatabase artifact routes #2187

Feat: implement CardanoDatabase artifact routes #2187

Uh oh!

Conversation

jpraynaud commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Issue(s)

Uh oh!

github-actions bot commented Dec 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

dlachaume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sfauvel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Alenar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Feat: implement `CardanoDatabase` artifact routes #2187

Feat: implement `CardanoDatabase` artifact routes #2187

jpraynaud commented Dec 18, 2024 •

edited

Loading

github-actions bot commented Dec 18, 2024 •

edited

Loading