Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 16, 2024

Content

This PR includes support for retryable errors when the underlying devnet bootstrap fails in the e2e tests in the CI.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #2176

@jpraynaud jpraynaud self-assigned this Dec 16, 2024
@github-actions
Copy link

Test Results

    4 files  ±0     52 suites  ±0   9m 54s ⏱️ +11s
1 428 tests ±0  1 428 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 639 runs  ±0  1 639 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f7681a3. ± Comparison against base commit 12c09d8.

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@jpraynaud jpraynaud merged commit dd43599 into main Dec 16, 2024
51 of 54 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2176-retryable-devnet-bootstrap-e2e-tests branch December 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make devnet bootstrap errors retryable

5 participants