Skip to content

Feat: add execute rights on pre-built binaries in CI #2156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

Feat: add execute rights on pre-built binaries in CI #2156

merged 1 commit into from
Dec 4, 2024

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Dec 3, 2024 •
edited
Loading

Content

This PR includes ensures that pre-built binaries in the CI have the execute permissions set.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Dec 3, 2024
@github-actions
Copy link

github-actions bot commented Dec 3, 2024

Test Results

    4 files  ±0     52 suites  ±0   11m 44s ⏱️ -1s
1 425 tests ±0  1 425 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 636 runs  ±0  1 636 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0cf9bd9. ± Comparison against base commit e6922b8.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet December 3, 2024 10:55 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 490e2c9 into main Dec 4, 2024
47 of 50 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/chmod-pre-built-binaries branch December 4, 2024 11:54
@jpraynaud jpraynaud added the devX 🌞 Developer experience label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

devX 🌞 Developer experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpraynaud @Alenar @sfauvel @dlachaume