Get rid of store adapter in aggregator #2143

sfauvel · 2024-11-25T17:03:23Z

Content

Replace the store using the legacy store adapter and replace them with a repository implementation in the Aggregator.

This PR includes:

Removing of StoreAdapter from persistence
Remove links to StoreAdapter for signer_registration and CertificatePending in Aggregator
Remove usage of AdapterError

Note

If pruning is unit tested, there is no test that verify that it's really plugged and worked in production.
It's just a configuration in build_upkeep_service function in the builder.rs file that activate it.

Pre-submit checklist

Branch
- Tests are provided (if possible)
- Crates versions are updated (if relevant)
- CHANGELOG file is updated (if relevant)
- Commit sequence broadly makes sense
- Key commits have useful messages
PR
- No clippy warnings in the CI
- Self-reviewed the diff
- Useful pull request description
- Reviewer requested
Documentation
- Update README file (if relevant)
- Update documentation website (if relevant)
- Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #2118

mithril-aggregator/src/http_server/routes/signer_routes.rs

github-actions · 2024-11-25T17:11:27Z

Test Results

4 files ± 0 51 suites ±0 11m 50s ⏱️ ±0s
1 414 tests - 45 1 414 ✅ - 45 0 💤 ±0 0 ❌ ±0
1 625 runs - 45 1 625 ✅ - 45 0 💤 ±0 0 ❌ ±0

Results for commit d01beb7. ± Comparison against base commit 94495a4.

♻️ This comment has been updated with latest results.

mithril-aggregator/src/database/record/certificate_pending.rs

mithril-aggregator/src/database/query/pending_certificate/save_pending_certificate.rs

mithril-aggregator/src/dependency_injection/builder.rs

internal/mithril-persistence/src/store/mod.rs

jpraynaud

Overall looks good 👍

I left few questions and suggestions.

mithril-aggregator/src/database/query/pending_certificate/get_pending_certificate.rs

mithril-aggregator/src/database/query/pending_certificate/save_pending_certificate.rs

mithril-aggregator/src/database/migration.rs

mithril-aggregator/src/database/record/certificate_pending.rs

mithril-aggregator/src/database/repository/signer_registration_store.rs

mithril-aggregator/src/database/test_helper.rs

mithril-aggregator/src/dependency_injection/builder.rs

mithril-aggregator/src/services/epoch_service.rs

dlachaume

LGTM 👍

mithril-aggregator/src/database/repository/pending_certificate_repository.rs

mithril-aggregator/src/dependency_injection/builder.rs

…le and use `projection_with_table`

…ingStore` that use the `StoreAdapter`

…the old one

* mithril-persistence from `0.2.36` to `0.2.37` * mithril-aggregator from `0.5.114` to `0.5.115`

jpraynaud

LGTM 🚀

github-advanced-security bot found potential problems Nov 25, 2024

View reviewed changes

mithril-aggregator/src/http_server/routes/signer_routes.rs Fixed Show fixed Hide fixed

sfauvel force-pushed the sfa/2118/get_rid_of_store_adapter_in_aggregator branch from 7363c3c to dae2e96 Compare November 26, 2024 09:41

sfauvel commented Nov 26, 2024

View reviewed changes

mithril-aggregator/src/database/record/certificate_pending.rs Outdated Show resolved Hide resolved

sfauvel commented Nov 26, 2024

View reviewed changes

mithril-aggregator/src/database/query/pending_certificate/save_pending_certificate.rs Outdated Show resolved Hide resolved

mithril-aggregator/src/dependency_injection/builder.rs Show resolved Hide resolved

sfauvel marked this pull request as ready for review November 26, 2024 10:23

sfauvel requested review from Alenar, dlachaume and jpraynaud November 26, 2024 10:23

sfauvel force-pushed the sfa/2118/get_rid_of_store_adapter_in_aggregator branch from dae2e96 to d0ba1ee Compare November 26, 2024 10:26

github-advanced-security bot found potential problems Nov 26, 2024

View reviewed changes

mithril-aggregator/src/dependency_injection/builder.rs Fixed Show fixed Hide fixed

sfauvel commented Nov 26, 2024

View reviewed changes

internal/mithril-persistence/src/store/mod.rs Show resolved Hide resolved

sfauvel force-pushed the sfa/2118/get_rid_of_store_adapter_in_aggregator branch 2 times, most recently from 20c0332 to e450847 Compare November 26, 2024 13:13

sfauvel temporarily deployed to testing-preview November 26, 2024 13:33 — with GitHub Actions Inactive

sfauvel temporarily deployed to testing-sanchonet November 26, 2024 13:33 — with GitHub Actions Inactive

jpraynaud reviewed Nov 26, 2024

View reviewed changes

dlachaume approved these changes Nov 26, 2024

View reviewed changes

mithril-aggregator/src/database/repository/pending_certificate_repository.rs Outdated Show resolved Hide resolved

mithril-aggregator/src/dependency_injection/builder.rs Outdated Show resolved Hide resolved

Alenar approved these changes Nov 26, 2024

View reviewed changes

sfauvel force-pushed the sfa/2118/get_rid_of_store_adapter_in_aggregator branch from d78085f to 61fd2ee Compare November 26, 2024 17:53

sfauvel added 10 commits November 27, 2024 16:26

Create a PendingCertificateRepository

33c577e

Rename column content to certificate in pending_certificate tab…

230ed9c

…le and use `projection_with_table`

Create a CertificatePendingStorer trait

0bd0e5d

Create a trait CertificatePendingStorer and remove `CertificatePend…

9639cfb

…ingStore` that use the `StoreAdapter`

Replace VerificationKeyStore by mock or real implementation in tests

fa378e3

Migrate pruning of signer registrations in the upkeep service

3a67c12

Remove StoreAdapter

64738e5

Replace get_projection_with_table by expand_projection

ff75cc5

Replace Fromby TryFrom to avoid panics

90c2be3

Some renaming

f2900f9

sfauvel added 2 commits November 27, 2024 16:30

Simplify fake data building in test

a4e979f

Add test on certificate pending to verify the new value is overwrite …

6bad9ab

…the old one

sfauvel force-pushed the sfa/2118/get_rid_of_store_adapter_in_aggregator branch from 28035c4 to 6bad9ab Compare November 27, 2024 15:30

sfauvel temporarily deployed to testing-preview November 27, 2024 15:39 — with GitHub Actions Inactive

sfauvel temporarily deployed to testing-sanchonet November 27, 2024 15:39 — with GitHub Actions Inactive

sfauvel added 2 commits November 27, 2024 16:41

Rename certificatecolumn and record field to pending_certificate

278ef1d

chore: upgrade crate versions

d01beb7

* mithril-persistence from `0.2.36` to `0.2.37` * mithril-aggregator from `0.5.114` to `0.5.115`

sfauvel temporarily deployed to testing-preview November 27, 2024 15:52 — with GitHub Actions Inactive

sfauvel temporarily deployed to testing-sanchonet November 27, 2024 15:52 — with GitHub Actions Inactive

jpraynaud approved these changes Nov 27, 2024

View reviewed changes

sfauvel temporarily deployed to testing-preview November 27, 2024 16:06 — with GitHub Actions Inactive

sfauvel temporarily deployed to testing-sanchonet November 27, 2024 16:06 — with GitHub Actions Inactive

sfauvel merged commit e38a254 into main Nov 27, 2024
50 checks passed

sfauvel deleted the sfa/2118/get_rid_of_store_adapter_in_aggregator branch November 27, 2024 16:07

Get rid of store adapter in aggregator #2143

Get rid of store adapter in aggregator #2143

Conversation

sfauvel commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Content

Pre-submit checklist

Comments

Issue(s)

Uh oh!

Uh oh!

github-actions bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dlachaume left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jpraynaud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sfauvel commented Nov 25, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading