Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented May 25, 2022

The Mithril Client is able to:

  • Retrieve the certificate associated to a snapshot from the Mithril Aggregator
  • Compute the digest of the downloaded snapshot archive
  • Verify the computed digest matches with the certificate digest
  • Verify the hash of the certificate is valid
  • Verify the validity of the multi signature in the certificate

Closes #180

@jpraynaud jpraynaud force-pushed the jpraynaud/180-client-uses-real-digest branch from d8591ce to 448f525 Compare May 25, 2022 16:51
@jpraynaud jpraynaud requested review from a user, Alenar and ghubertpalo May 25, 2022 16:52
@github-actions
Copy link

github-actions bot commented May 25, 2022

Unit Test Results

    5 files  ±0    14 suites  ±0   2m 13s ⏱️ -18s
140 tests +6  140 ✔️ +6  0 💤 ±0  0 ±0 

Results for commit ae10e2c. ± Comparison against base commit 0be8dd1.

This pull request removes 6 and adds 12 tests. Note that renamed tests count towards both.
client::tests ‑ test_list_snapshots_ko
client::tests ‑ test_list_snapshots_ok
client::tests ‑ test_restore_snapshot_ok
client::tests ‑ test_restore_unpack_snapshot
client::tests ‑ test_show_snapshot_ko
client::tests ‑ test_show_snapshot_ok
runtime::tests ‑ test_list_snapshots_ko
runtime::tests ‑ test_list_snapshots_ok
runtime::tests ‑ test_restore_snapshot_ko_certificate_hash_not_matching
runtime::tests ‑ test_restore_snapshot_ko_digester_error
runtime::tests ‑ test_restore_snapshot_ko_digests_not_matching
runtime::tests ‑ test_restore_snapshot_ko_get_certificate_details
runtime::tests ‑ test_restore_snapshot_ko_get_snapshot_details
runtime::tests ‑ test_restore_snapshot_ko_restore_unpack_snapshot
runtime::tests ‑ test_restore_snapshot_ko_verify_multi_signature
runtime::tests ‑ test_restore_snapshot_ok
…

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/180-client-uses-real-digest branch from 448f525 to ae10e2c Compare May 30, 2022 14:15
@jpraynaud jpraynaud merged commit 00753e9 into main May 30, 2022
@jpraynaud jpraynaud deleted the jpraynaud/180-client-uses-real-digest branch May 30, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mithril Client computes digest from snapshot

3 participants