-
Notifications
You must be signed in to change notification settings - Fork 51
Also bump versions of js packages in upgrade version script #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also bump versions of js packages in upgrade version script #2137
Conversation
b18c42f to
d52041a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one remark
72ac8f3 to
e56012b
Compare
…and_openapi_versions.sh`
To better reflect the fact that not only rust crates are updated but also js packages.
6a13ecc to
c448a9a
Compare
c448a9a to
2fab021
Compare
Content
This PR add to the upgrade version scrip in the devbook the capacity to bump js packages versions and rename it from
upgrade-crates-and-openapi-versionsto simplybump-versions.It works the following way:
package.jsonfiles in the project, excluding those auto-generated or from imported packagesmainbranch in apackage.jsondirectorynpm version patchto bump the patch version (with--no-git-tag-versionto handle the commit our-self)Note
docs/website/is excluded as we don't want to bump its version if its articles or blog posts changed.Pre-submit checklist