Skip to content

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Nov 22, 2024

Content

This PR add to the upgrade version scrip in the devbook the capacity to bump js packages versions and rename it from upgrade-crates-and-openapi-versions to simply bump-versions.

It works the following way:

  1. Detect all package.json files in the project, excluding those auto-generated or from imported packages
  2. If there was a change compared to the main branch in a package.json directory
    • In dry run only print the updated version
    • else use npm version patch to bump the patch version (with --no-git-tag-version to handle the commit our-self)
  3. Append the modified versions to the commit message

Note

docs/website/ is excluded as we don't want to bump its version if its articles or blog posts changed.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)

@Alenar Alenar added the devX 🌞 Developer experience label Nov 22, 2024
@Alenar Alenar self-assigned this Nov 22, 2024
@Alenar Alenar force-pushed the ensemble/add-js-packages-to-upgrade-version-scripts branch from b18c42f to d52041a Compare November 22, 2024 15:11
@github-actions
Copy link

github-actions bot commented Nov 22, 2024

Test Results

    4 files  ±0     51 suites  ±0   11m 50s ⏱️ +10s
1 455 tests ±0  1 455 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 666 runs  ±0  1 666 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2fab021. ± Comparison against base commit ad40680.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview November 22, 2024 15:23 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet November 22, 2024 15:23 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one remark

@Alenar Alenar force-pushed the ensemble/add-js-packages-to-upgrade-version-scripts branch 2 times, most recently from 72ac8f3 to e56012b Compare November 25, 2024 12:11
@Alenar Alenar temporarily deployed to testing-preview November 25, 2024 12:24 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet November 25, 2024 12:24 — with GitHub Actions Inactive
To better reflect the fact that not only rust crates are updated but
also js packages.
@Alenar Alenar force-pushed the ensemble/add-js-packages-to-upgrade-version-scripts branch 2 times, most recently from 6a13ecc to c448a9a Compare November 25, 2024 14:06
@Alenar Alenar force-pushed the ensemble/add-js-packages-to-upgrade-version-scripts branch from c448a9a to 2fab021 Compare November 25, 2024 14:10
@Alenar Alenar temporarily deployed to testing-preview November 25, 2024 14:22 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet November 25, 2024 14:22 — with GitHub Actions Inactive
@Alenar Alenar merged commit 008d16f into main Nov 25, 2024
47 checks passed
@Alenar Alenar deleted the ensemble/add-js-packages-to-upgrade-version-scripts branch November 25, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devX 🌞 Developer experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants