Explorer: Easier, more cohesive, aggregator controls #2132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
changed the title
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
approved these changes
Nov 19, 2024
mithril-explorer/src/components/ControlPanel/IntervalSetter/index.js
Outdated
Show resolved
Hide resolved
+ Add a 'Off' option in the update interval select to replace the 'pause'.
…atus In order to move the after the 'Aggregator' title row. + Remove their labels to reclaim some vertical space
…aggregator status - remove its header - move its 'raw json' button to its card footer - make it collapsable
…ta and refresh interval in a `ControlPanel` component
Alenar
force-pushed
the
djo/explorer/regroup-aggregator-control-status
branch
from
2347bee to
5f15458
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR reworks the explorer upper part (that contains the aggregator selection, status and refresh interval setter) to make it more easier to use and free some space:
Group refresh interval, aggregator selection, aggregator status/epoch setting into a
ControlPanelcomponent to make the code more cohesiveReplace
Aggregator StatusandEpoch Settingtitles with aAggregatortitle that is before the aggregator and refresh interval selectorsRemove labels on the aggregator selection and refresh interval setter to free some vertical space
Interval setter:
play/pausebutton with aRefreshbuttonOffvalue to the available options to stop the automatic refreshPrevious button was ambiguous and made little sense and if we only want to refresh once we had to click on it twice, by regrouping all the interval values in the options and adding a dedicated button the UI should be easier to use.
Make the
EpochSettingscomponent collapsible the same way as the aggregator status (for aggregators that does not yet support the/statusroute)Demo:
Screencast from 2024-11-19 16-25-00.webm
Pre-submit checklist