Add a database migration to remove network from cardano immutable files full beacons
#2113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es full beacons As keeping them lead the signer and aggregator to think that they have not produced a signature for the latest immutable files full snapshot (because when the check is done in db it use the serialized json representation that have changed with the network removal).
dlachaume
approved these changes
Nov 14, 2024
* mithril-aggregator from `0.5.111` to `0.5.112` * mithril-signer from `0.2.213` to `0.2.214`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
deleted the
djo/1957/remove_network_from_cardano_db_beacon_in_db
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a migration in both the signer and the aggregator to remove remaining
networkin cardano immutable files full beacons stored in database.Keeping them lead the signer and aggregator to think that they have not produced a signature for the latest immutable files full snapshot when they are upgraded to the changes introduced with PR #2110.
This happens because when this check is done in database it use the serialized json representation (stored in the
open_messagetable for aggregator,signed_beacontable for signer) and this json has changed with the network removal.Pre-submit checklist
Issue(s)
Relates to #1957