Skip to content

Fix: adjust era offset in PallasChainObserver for correct display name #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix: adjust era offset in PallasChainObserver for correct display name #2112

merged 2 commits into from
Nov 14, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 14, 2024 •
edited
Loading

Content

This PR includes a fix for the retrieval of the Cardano era in the PallasChainObserver to ensure the correct era display name is returned. The offset is adjusted to align with the era mapping differences in the Cardano node implementation.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2111

@dlachaume dlachaume self-assigned this Nov 14, 2024
jpraynaud
jpraynaud approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the ensemble/2111/add-offset-for-era-conversion-with-pallas-observer branch 2 times, most recently from 040a96d to 2663847 Compare November 14, 2024 12:00
@dlachaume dlachaume requested review from Alenar and sfauvel November 14, 2024 12:00
@github-actions
Copy link

github-actions bot commented Nov 14, 2024 •
edited
Loading

Test Results

    4 files     51 suites   11m 48s ⏱️
1 445 tests 1 445 ✅ 0 💤 0 ❌
1 656 runs  1 656 ✅ 0 💤 0 ❌

Results for commit d279713.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet November 14, 2024 12:09 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the ensemble/2111/add-offset-for-era-conversion-with-pallas-observer branch from 2663847 to d279713 Compare November 14, 2024 13:21
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 14, 2024 13:32 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 85bc542 into main Nov 14, 2024
50 checks passed
@dlachaume dlachaume deleted the ensemble/2111/add-offset-for-era-conversion-with-pallas-observer branch November 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cardano era in status page of aggregator is incorrect

4 participants

@dlachaume @Alenar @jpraynaud