Skip to content

Conversation

@sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Nov 12, 2024

Content

This PR remove the pruning from the save function and use the upkeep service instead.
The StakeStore is moved from persistence to signer.
The EpochPruningTask is implemented over the StorePruner in the Signer for the ProtocolInitializerStore and StakeStore.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2075

@github-actions
Copy link

github-actions bot commented Nov 12, 2024

Test Results

    4 files  ±0     51 suites  ±0   11m 5s ⏱️ +21s
1 441 tests ±0  1 441 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 652 runs  ±0  1 652 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d9ca627. ± Comparison against base commit 0a7fb9f.

This pull request removes 7 and adds 7 tests. Note that renamed tests count towards both.
mithril-persistence ‑ store::stake_store::tests::check_retention_limit
mithril-persistence ‑ store::stake_store::tests::get_stakes_for_empty_epoch
mithril-persistence ‑ store::stake_store::tests::get_stakes_for_existing_epoch
mithril-persistence ‑ store::stake_store::tests::retrieve_returns_stake_distribution
mithril-persistence ‑ store::stake_store::tests::retrieve_with_no_stakes_returns_none
mithril-persistence ‑ store::stake_store::tests::save_key_in_empty_store
mithril-persistence ‑ store::stake_store::tests::update_signer_in_store
mithril-signer ‑ store::stake_store::tests::check_retention_limit
mithril-signer ‑ store::stake_store::tests::get_stakes_for_empty_epoch
mithril-signer ‑ store::stake_store::tests::get_stakes_for_existing_epoch
mithril-signer ‑ store::stake_store::tests::retrieve_returns_stake_distribution
mithril-signer ‑ store::stake_store::tests::retrieve_with_no_stakes_returns_none
mithril-signer ‑ store::stake_store::tests::save_key_in_empty_store
mithril-signer ‑ store::stake_store::tests::update_signer_in_store

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-sanchonet November 12, 2024 18:16 — with GitHub Actions Inactive
@sfauvel sfauvel requested review from Alenar and dlachaume November 13, 2024 08:39
@sfauvel sfauvel marked this pull request as ready for review November 13, 2024 08:39
@sfauvel sfauvel requested a review from jpraynaud November 13, 2024 08:40
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sfauvel sfauvel force-pushed the sfa/2075/refactor_signer_pruning_with_upkeep_service branch from 4e5fbe0 to d9ca627 Compare November 13, 2024 13:15
@sfauvel sfauvel temporarily deployed to testing-sanchonet November 13, 2024 13:27 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit e274a5d into main Nov 13, 2024
50 checks passed
@sfauvel sfauvel deleted the sfa/2075/refactor_signer_pruning_with_upkeep_service branch November 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor pruning with upkeep service in signer/aggregator

5 participants