-
Notifications
You must be signed in to change notification settings - Fork 51
Feat: add genesis generate-keypair command in aggregator
#2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jpraynaud
merged 7 commits into
main
from
jpraynaud/2074-aggregator-command-create-genesis-keypair
Nov 13, 2024
Merged
Feat: add genesis generate-keypair command in aggregator
#2106
jpraynaud
merged 7 commits into
main
from
jpraynaud/2074-aggregator-command-create-genesis-keypair
Nov 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99fa30b to
5542ca0
Compare
dlachaume
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
dlachaume
reviewed
Nov 12, 2024
sfauvel
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Alenar
approved these changes
Nov 13, 2024
4f092c5 to
a4da207
Compare
- 'mithril-aggregator' from '0.5.108' to '0.5.109' - 'mithril-common' from '0.4.84' to '0.4.85'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes the implementation and documentation of the new
genesis generate-keypaircommand in the aggregator that is used to create Genesis keypairs.Documentation Updates:
generate-keypaircommand to the list of subcommands inmithril-aggregator.md.generate-keypaircommand inmithril-aggregator.md.Command Implementation:
GenerateKeypairvariant to theGenesisSubCommandenum ingenesis_command.rs.executemethod for theGenerateKeypairGenesisSubCommandstruct ingenesis_command.rs.Utility Functions:
create_and_save_genesis_keypairfunction toGenesisToolsingenesis.rs.export_keypair_to_filesmethod inProtocolGenesisSignerto export both secret and verification keys ingenesis.rs.Test Updates:
create_and_save_genesis_keypairfunction ingenesis.rs.genesis.rs.Pre-submit checklist
Issue(s)
Closes #2074