Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Nov 12, 2024

Content

This PR includes the implementation and documentation of the new genesis generate-keypair command in the aggregator that is used to create Genesis keypairs.

Documentation Updates:

  • Added generate-keypair command to the list of subcommands in mithril-aggregator.md.
  • Documented parameters for the generate-keypair command in mithril-aggregator.md.

Command Implementation:

  • Added GenerateKeypair variant to the GenesisSubCommand enum in genesis_command.rs.
  • Implemented the execute method for the GenerateKeypairGenesisSubCommand struct in genesis_command.rs.

Utility Functions:

  • Added create_and_save_genesis_keypair function to GenesisTools in genesis.rs.
  • Updated the export_keypair_to_files method in ProtocolGenesisSigner to export both secret and verification keys in genesis.rs.

Test Updates:

  • Added a test for the create_and_save_genesis_keypair function in genesis.rs.
  • Modified existing tests to use the new keypair export function in genesis.rs.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website (if relevant)

Issue(s)

Closes #2074

@jpraynaud jpraynaud self-assigned this Nov 12, 2024
@jpraynaud jpraynaud force-pushed the jpraynaud/2074-aggregator-command-create-genesis-keypair branch from 99fa30b to 5542ca0 Compare November 12, 2024 15:15
@github-actions
Copy link

github-actions bot commented Nov 12, 2024

Test Results

    4 files  ±0     51 suites  ±0   11m 9s ⏱️ -17s
1 443 tests +2  1 443 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 654 runs  +2  1 654 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 8b1ec90. ± Comparison against base commit e274a5d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/2074-aggregator-command-create-genesis-keypair branch from 4f092c5 to a4da207 Compare November 13, 2024 13:37
- 'mithril-aggregator' from '0.5.108' to '0.5.109'
- 'mithril-common' from '0.4.84' to '0.4.85'.
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet November 13, 2024 13:49 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 913172d into main Nov 13, 2024
50 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2074-aggregator-command-create-genesis-keypair branch November 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add command to create Genesis keypair in aggregator

5 participants