Skip to content

Feat: add Cardano era retrieval in chain observer implementations #2094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2024
Merged

Feat: add Cardano era retrieval in chain observer implementations #2094

merged 4 commits into from
Nov 7, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 6, 2024 •
edited
Loading

Content

This PR includes the retrieval of the current Cardano era in both the CardanoCliChainObserver and PallasChainObserver.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2071

@dlachaume dlachaume self-assigned this Nov 6, 2024
@github-actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   10m 25s ⏱️ -12s
1 417 tests +2  1 417 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 628 runs  +2  1 628 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 73d1fd4. ± Comparison against base commit 6f6aed3.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet November 6, 2024 10:19 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2071/create-new-status-route branch from 580ebbc to 1a840c1 Compare November 6, 2024 11:17
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 6, 2024 11:26 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume temporarily deployed to testing-sanchonet November 6, 2024 13:34 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
just a little thought on writing tests

@dlachaume dlachaume force-pushed the dlachaume/2071/create-new-status-route branch from 526eac0 to c257754 Compare November 6, 2024 17:31
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 6, 2024 17:40 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2071/create-new-status-route branch 3 times, most recently from 63c9b20 to 2cb5e47 Compare November 7, 2024 11:11
sfauvel
sfauvel approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume temporarily deployed to testing-sanchonet November 7, 2024 11:19 — with GitHub Actions Inactive
@dlachaume
test: refactor test_cli_runner to improve test readability
0b3f614
@dlachaume
chore: upgrade crate versions
73d1fd4 
* mithril-aggregator from `0.5.104` to `0.5.105`
* mithril-common from `0.4.80` to `0.4.81`
@dlachaume dlachaume force-pushed the dlachaume/2071/create-new-status-route branch from 2cb5e47 to 73d1fd4 Compare November 7, 2024 13:22
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 7, 2024 13:34 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 1beff79 into main Nov 7, 2024
50 checks passed
@dlachaume dlachaume deleted the dlachaume/2071/create-new-status-route branch November 7, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

+1 more reviewer

@sfauvel sfauvel sfauvel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dlachaume @Alenar @sfauvel @jpraynaud