Skip to content

Feat: custom signed entity types in backward compatibility test in CI #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

Feat: custom signed entity types in backward compatibility test in CI #2087

merged 2 commits into from
Nov 5, 2024

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Nov 5, 2024 •
edited
Loading

Content

This PR updates the nightly backward compatibility workflow to include signed entity types

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2027

@jpraynaud jpraynaud self-assigned this Nov 5, 2024
@github-actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   10m 34s ⏱️ +4s
1 418 tests ±0  1 418 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 629 runs  ±0  1 629 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3983325. ± Comparison against base commit f67adf1.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet November 5, 2024 12:15 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpraynaud jpraynaud force-pushed the jpraynaud/2027-custom-signed-entity-types-nightly-backward-compatibility branch from ce0e1ae to 3983325 Compare November 5, 2024 13:43
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet November 5, 2024 14:00 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit d1cf625 into main Nov 5, 2024
100 of 111 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2027-custom-signed-entity-types-nightly-backward-compatibility branch November 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpraynaud @Alenar @sfauvel @dlachaume