Skip to content

Feat: add latest shortcut as targeted era for Cardano CLI commands #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2024
Merged

Feat: add latest shortcut as targeted era for Cardano CLI commands #2085

merged 3 commits into from
Nov 5, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Nov 4, 2024 •
edited
Loading

Content

This PR includes an update to the Cardano CLI calls by adding the latest shortcut as a targeted era for Cardano CLI commands.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2072

@dlachaume dlachaume self-assigned this Nov 4, 2024
@github-actions
Copy link

github-actions bot commented Nov 4, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   10m 35s ⏱️ -7s
1 418 tests ±0  1 418 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 629 runs  ±0  1 629 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9f75399. ± Comparison against base commit 49a411c.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet November 4, 2024 17:23 — with GitHub Actions Inactive
Alenar
Alenar reviewed Nov 4, 2024
View reviewed changes
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 4, 2024 17:55 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/2072/update-cardano-cli-calls branch from 8eea1e2 to 8c73b17 Compare November 5, 2024 08:38
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 5, 2024 09:13 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/2072/update-cardano-cli-calls branch from 8c73b17 to 9f75399 Compare November 5, 2024 11:04
@dlachaume dlachaume temporarily deployed to testing-sanchonet November 5, 2024 11:19 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit f67adf1 into main Nov 5, 2024
50 checks passed
@dlachaume dlachaume deleted the dlachaume/2072/update-cardano-cli-calls branch November 5, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

+1 more reviewer

@sfauvel sfauvel sfauvel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Cardano CLI calls to new interface

5 participants

@dlachaume @Alenar @sfauvel @jpraynaud