Skip to content

Record aggregator metrics in event store #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 30, 2024
Merged

Record aggregator metrics in event store #2059

merged 13 commits into from
Oct 30, 2024

Conversation

@sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Oct 29, 2024 •
edited
Loading

Content

Store usage metrics in the event store of the aggregator in order to produce statistics reports.

The new service usage_report sending events at regular intervals to the ̀event store. The frequency of measurement taking can be configured by setting PERSIST_USAGE_REPORT_INTERVAL_IN_SECONDS` environment variable.

The view metrics_per_day calculate the value of each metric over a day.

This feature is described in the runbook aggregator-metrics.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #2023

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 29, 2024
View reviewed changes
@sfauvel sfauvel force-pushed the sfauvel/2023/record_aggregator_metrics_in_event_store branch from 0ba2750 to 48a2e41 Compare October 29, 2024 15:32
@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Test Results

    4 files  ± 0     51 suites  ±0   10m 27s ⏱️ -3s
1 415 tests +15  1 415 ✅ +15  0 💤 ±0  0 ❌ ±0 
1 626 runs  +15  1 626 ✅ +15  0 💤 ±0  0 ❌ ±0 

Results for commit 10703b4. ± Comparison against base commit bd9b7be.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel force-pushed the sfauvel/2023/record_aggregator_metrics_in_event_store branch 2 times, most recently from 32d0abb to 24d0723 Compare October 29, 2024 15:53
@sfauvel sfauvel temporarily deployed to testing-preview October 29, 2024 16:04 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 29, 2024 16:04 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review October 29, 2024 16:06
@sfauvel sfauvel force-pushed the sfauvel/2023/record_aggregator_metrics_in_event_store branch from 24d0723 to 6eea73d Compare October 29, 2024 16:20
@sfauvel sfauvel temporarily deployed to testing-preview October 29, 2024 16:28 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 29, 2024 16:28 — with GitHub Actions Inactive
jpraynaud
jpraynaud reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍

I left few suggestions and comments below.

Alenar
Alenar approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

dlachaume
dlachaume approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2024
View reviewed changes
@sfauvel sfauvel force-pushed the sfauvel/2023/record_aggregator_metrics_in_event_store branch from 1aa3b31 to 17aaecd Compare October 30, 2024 15:51
@sfauvel sfauvel temporarily deployed to testing-preview October 30, 2024 16:00 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 30, 2024 16:00 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfauvel/2023/record_aggregator_metrics_in_event_store branch from 17aaecd to 18a2f8b Compare October 30, 2024 16:27
@sfauvel sfauvel temporarily deployed to testing-preview October 30, 2024 16:35 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 30, 2024 16:35 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sfauvel
Ensure that not supported metrics by export_metrics_map are not used
0143189
@sfauvel
chore: upgrade crate versions
10703b4 
* mithril-aggregator from `0.5.94` to `0.5.95`
* mithril-end-to-end from `0.4.43` to `0.4.44`
@sfauvel sfauvel temporarily deployed to testing-preview October 30, 2024 17:40 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 30, 2024 17:40 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 678e6e9 into main Oct 30, 2024
47 checks passed
@sfauvel sfauvel deleted the sfauvel/2023/record_aggregator_metrics_in_event_store branch October 30, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

+1 more reviewer

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Record aggregator metrics in event store

5 participants

@sfauvel @Alenar @jpraynaud @dlachaume