Skip to content

Ensemble/1958/fix explorer #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

Ensemble/1958/fix explorer #2056

merged 2 commits into from
Oct 28, 2024

Conversation

@Alenar
Copy link
Collaborator

@Alenar Alenar commented Oct 28, 2024 •
edited
Loading

Content

This PR includes a fix for the explorer who had e.beacon is undefined errors on testing network plus when validating transactions since the merge of #2055.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1958

Alenar added 2 commits October 28, 2024 16:38
@Alenar
fix(explorer): adapt to certificate beacon removal
cb42be1 
Else explorer crash with a `e.beacon is undefined` logged in the console.
@Alenar
chore: bump explorer version from 0.7.11 to 0.7.12
7246c53
@Alenar Alenar added the bug ⚠️ Something isn't working label Oct 28, 2024
@Alenar Alenar self-assigned this Oct 28, 2024
@github-actions
Copy link

github-actions bot commented Oct 28, 2024

Test Results

    4 files  ±0     51 suites  ±0   10m 29s ⏱️ -7s
1 398 tests ±0  1 398 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 609 runs  ±0  1 609 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7246c53. ± Comparison against base commit 5d38bce.

@Alenar Alenar temporarily deployed to testing-preview October 28, 2024 15:50 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet October 28, 2024 15:50 — with GitHub Actions Inactive
@Alenar Alenar merged commit e68fb58 into main Oct 28, 2024
47 checks passed
@Alenar Alenar deleted the ensemble/1958/fix_explorer branch October 28, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Alenar Alenar

Labels

bug ⚠️ Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Alenar @sfauvel @jpraynaud @dlachaume