Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 21, 2024

Content

This PR includes a fix to the chaining computation of the certificate chain in tests:

The previous certificate is either:

  • the first certificate of the previous epoch if the certificate is the first of the epoch
  • otherwise the first certificate of the epoch

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Oct 21, 2024
@github-actions
Copy link

github-actions bot commented Oct 21, 2024

Test Results

    4 files     55 suites   10m 35s ⏱️
1 395 tests 1 395 ✅ 0 💤 0 ❌
1 609 runs  1 609 ✅ 0 💤 0 ❌

Results for commit 199d6c5.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Something strange in tests.

…n builder

Previous certificate is either:
- the first certificate of the previous epoch if the certificate is the
  first of the epoch
- otherwise the first certificate of the epoch.
- 'mithril-common' from '0.4.73' to '0.4.74'.
@jpraynaud jpraynaud force-pushed the jpraynaud/fix-certificate-chain-chaining branch from 4354dea to 199d6c5 Compare October 22, 2024 15:48
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 22, 2024 16:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 0cbc482 into main Oct 22, 2024
48 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/fix-certificate-chain-chaining branch October 22, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants