Sfauvel/1990/refactor prometheus metrics using struct #1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sfauvel
force-pushed
the
sfauvel/1990/refactor_prometheus_metrics_using_struct
branch
from
44573fe to
5f32339
Compare
jpraynaud
reviewed
Oct 14, 2024
dlachaume
reviewed
Oct 14, 2024
sfauvel
force-pushed
the
sfauvel/1990/refactor_prometheus_metrics_using_struct
branch
3 times, most recently
from
3090752 to
1c87643
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
approved these changes
Oct 15, 2024
…`in `MetricCounter`
…xport_metrics` function create by the macro and remove `metrics_tools`
…om generic in `MetricGauge::record` function and the `round` in getter
sfauvel
force-pushed
the
sfauvel/1990/refactor_prometheus_metrics_using_struct
branch
from
0746b9d to
cedeb26
Compare
* mithril-metric from `0.0.1` to `0.1.0` * mithril-common from `0.4.70` to `0.4.71` * mithril-signer from `0.2.201` to `0.2.202`
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
deleted the
sfauvel/1990/refactor_prometheus_metrics_using_struct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Create a new crate
internal/mithril-metricsthat provide tooling to simplify the creation of a metric service.This PR includes the creation of a new crate that provide a MetricServer and a macro to simply declare a new metric service.
Pre-submit checklist
Comments
Functions to update metrics are not removed to avoid too many change in the Signer. It will be done later.
Issue(s)
Closes #1990