Refactor(aggregator): simplify http server dependencies #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Alenar
force-pushed
the
djo/aggregator-simplify-http-server-dependencies
branch
from
fc27351 to
e151a55
Compare
By providing the dependency container by reference instead of by move, allowing to remove the numerous `.clone()` used before.
sfauvel
approved these changes
Oct 11, 2024
Alenar
force-pushed
the
djo/aggregator-simplify-http-server-dependencies
branch
from
e151a55 to
c42cbb1
Compare
* mithril-aggregator from `0.5.79` to `0.5.80`
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR simplify the aggregator http server dependencies by providing the dependency container by reference instead of by move, allowing to remove the numerous
.clone()used before.Pre-submit checklist