Skip to content

Fix: aggregator panics in CI #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2024
Merged

Fix: aggregator panics in CI #1995

merged 3 commits into from
Oct 10, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 10, 2024 •
edited
Loading

Content

This PR includes a modification that disables store pruning for genesis commands, an operation that is unnecessary in this context.
An issue was identified through E2E tests and was causing a panic during the pruning of the epoch setting table: https://github.com/input-output-hk/mithril/actions/runs/11146785295/job/30979818861#step:6:642

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1983

@dlachaume dlachaume changed the title [TMP] add more E2E runs Fix: aggregator panics in CI Oct 10, 2024
@dlachaume dlachaume self-assigned this Oct 10, 2024
@github-actions
Copy link

github-actions bot commented Oct 10, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 32s ⏱️ +9s
1 351 tests ±0  1 351 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 559 runs  ±0  1 559 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6627cd1. ± Comparison against base commit d76dc5f.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the ensemble/investigate-aggregator-panics branch from a477d32 to a0ab133 Compare October 10, 2024 15:08
@dlachaume dlachaume force-pushed the ensemble/investigate-aggregator-panics branch from a0ab133 to 6627cd1 Compare October 10, 2024 15:16
jpraynaud
jpraynaud approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume marked this pull request as ready for review October 10, 2024 15:22
@dlachaume dlachaume temporarily deployed to testing-sanchonet October 10, 2024 15:28 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit b541890 into main Oct 10, 2024
48 checks passed
@dlachaume dlachaume deleted the ensemble/investigate-aggregator-panics branch October 10, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aggregator panics when handling discrepancies at startup in CI

4 participants

@dlachaume @Alenar @jpraynaud