Make epoch mandatory in RegisterSignerMessage
#1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 4 files ±0 54 suites ±0 9m 19s ⏱️ -1s Results for commit 525751e. ± Comparison against base commit 322a8ce. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
This is non-breaking since the epoch is sent by all signers since version `0.2.36` released with distribution `2318` more than a year and half ago (no signers are running older versions anymore).
* mithril-aggregator from `0.5.74` to `0.5.75` * mithril-common from `0.4.64` to `0.4.65` * mithril-signer from `0.2.194` to `0.2.195` * mithril-end-to-end from `0.4.34` to `0.4.35`
Alenar
force-pushed
the
djo/1956/non_optional_epoch_in_register_signer_msg
branch
from
ac75149 to
525751e
Compare
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR refactor the
RegisterSignerMessagein order to make its epoch field mandatory, allowing to simplify the code that used it.This is non-breaking since the epoch is sent by all signers since version
0.2.36released with distribution2318more than a year and half ago (no signers are running older versions anymore).Pre-submit checklist
Issue(s)
Closes #1956