Skip to content

Chore: decommission testing-mainnet network #1978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 7, 2024
Merged

Chore: decommission testing-mainnet network #1978

merged 4 commits into from
Oct 7, 2024
+6 −35

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 4, 2024 •
edited
Loading

Content

This PR includes the decommission of the testing-mainnet network which is no longer used.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Oct 4, 2024
@github-actions
Copy link

github-actions bot commented Oct 4, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 23s ⏱️ -12s
1 330 tests ±0  1 330 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 541 runs  ±0  1 541 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e716936. ± Comparison against base commit 390e545.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 4, 2024 13:33 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

sfauvel
sfauvel approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alenar
Alenar approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

About the files still in the infrastructure (mithril-infra/configuration/testing-mainnet) do you want to delete them later ?

@jpraynaud
Copy link
Member Author

jpraynaud commented Oct 7, 2024

LGTM 🚀

About the files still in the infrastructure (mithril-infra/configuration/testing-mainnet) do you want to delete them later ?

Thanks for pointing that out, I have removed them in 5642b68 👍

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 7, 2024 12:17 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit a95ace1 into main Oct 7, 2024
43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/decommission-testing-mainnet branch October 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpraynaud @Alenar @sfauvel @dlachaume