Skip to content

Feat: sign protocol parameters in Genesis certificate #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 24, 2024
Merged

Feat: sign protocol parameters in Genesis certificate #1950

merged 9 commits into from
Sep 24, 2024

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 23, 2024 •
edited
Loading

Content

This PR includes an upgrade of the Genesis certificate to embed the protocol parameters of the next epoch.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Sep 23, 2024
@github-actions
Copy link

github-actions bot commented Sep 23, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 42s ⏱️ -7s
1 297 tests +2  1 297 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 508 runs  +2  1 508 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 9c62875. ± Comparison against base commit 04bd838.

♻️ This comment has been updated with latest results.

dlachaume
dlachaume approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Alenar
Alenar approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jpraynaud jpraynaud force-pushed the jpraynaud/sign-protocol-parameters-genesis-certificate branch from d8e46ea to 9c62875 Compare September 24, 2024 15:01
@jpraynaud jpraynaud merged commit 17b94ba into main Sep 24, 2024
48 of 66 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/sign-protocol-parameters-genesis-certificate branch September 24, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@curiecrypt curiecrypt Awaiting requested review from curiecrypt

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpraynaud @Alenar @sfauvel @dlachaume