Skip to content

Fix: data inconsistency in Cardano transactions stores #1936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

Fix: data inconsistency in Cardano transactions stores #1936

merged 3 commits into from
Sep 18, 2024
+48 −15

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Sep 16, 2024 •
edited
Loading

Content

This PR includes a fix that prevents data inconsistency in the Cardano transactions store if it has been created with stale versions of the signer.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1901
Closes #1938

@jpraynaud jpraynaud self-assigned this Sep 16, 2024
@github-actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Test Results

    4 files  ±0     53 suites  ±0   9m 38s ⏱️ +9s
1 252 tests ±0  1 252 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 463 runs  ±0  1 463 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 99e2300. ± Comparison against base commit ebb4030.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1901-fix-data-inconsistency-cardano-transaction branch from e74b8b3 to d59cc07 Compare September 16, 2024 10:25
jpraynaud and others added 3 commits September 18, 2024 14:54
@jpraynaud @Alenar
fix: reset Cardano transactions store with a migration
f3b4e8b 
This will avoid data inconsistency with nodes running previous unstable versions.
@Alenar
Add debug logs to PallasChainReader
6795b3b
@jpraynaud @Alenar
chore: bump crates versions
99e2300 
- 'mithril-persistence' from '0.2.26' to '0.2.27'
- 'mithril-aggregator' from '0.5.62' to '0.5.63'
- 'mithril-signer' from '0.2.181' to '0.2.182'
@Alenar Alenar force-pushed the jpraynaud/1901-fix-data-inconsistency-cardano-transaction branch from d59cc07 to 99e2300 Compare September 18, 2024 12:55
@Alenar Alenar temporarily deployed to testing-sanchonet September 18, 2024 13:06 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 9fd9ae8 into main Sep 18, 2024
39 of 40 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1901-fix-data-inconsistency-cardano-transaction branch September 18, 2024 13:08
@jpraynaud jpraynaud mentioned this pull request Sep 18, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cardano transactions certification stopped in pre-release-preview

5 participants

@jpraynaud @Alenar @sfauvel @dlachaume