-
Notifications
You must be signed in to change notification settings - Fork 52
Aggregator single signatures buffer #1934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
e02968d
Scaffold integration test for signing with buffered signatures
Alenar b038620
Uncouple signatures registration from certifier in integration tests
Alenar 33bd027
Promote aggregator `certifier` module to directory
Alenar 047e26b
Rearrange `certifier` module
Alenar 10af4a0
Scaffold `BufferedCertifierService` decorator
Alenar c6b0d45
Define a store for buffered signatures with an in-memory impl
Alenar 4c203a5
Make buffer certifier buffer signature if no open message is available
Alenar fa55f44
Make buffered certifier add buffered signatures when opening a new me…
Alenar 40dcab7
Add a dedicated error when registering invalid single signatures in c…
Alenar ec0053d
Move `InMemoryBufferedSingleSignatureStore` to store module
Alenar 9ad80bd
Don't fail but log when transferring buffered signatures to new message
Alenar eeef280
Scaffold a sqlite BufferedSingleSignatureStore
Alenar 0821617
Remove epoch from `BufferedSingleSignatureRecord`
Alenar 795d3eb
Add unique constraint on `buffered_single_signature:signature` column
Alenar d7e4c0d
Fix crypto_helper:setup_protocol_initializer crash if party id is les…
Alenar 5a7f9ea
Fix buffered_single_signature table constraints
Alenar 407e481
Implement `buffer_signature` on sqlite store
Alenar b37bcfe
Implement `remove_buffered_signatures` on sqlite store
Alenar f07dafd
Remove unique(signature) constraint on buffered sig table
Alenar c3d1b0f
Skip invalid signatures when registering buffered data
Alenar 20981a1
Remove RwLock wrapping from aggregator multi-signer
Alenar 9aac986
Add `AsMessage` trait to allow multiple type to be sign or verified
Alenar 44ad88b
Make aggregator multi signer able to verify signature issued for the …
Alenar 028cf29
Check signature against message before buffering
Alenar c7f0878
Check signature against message using next stake distribution
Alenar a903d92
Add a status to certifier signature registration
Alenar d9185fe
Use sqlite store in buffered certifier tests
Alenar 34a7219
Use sqlite buffer store everywhere and remove in memory version
Alenar 76ffeae
Add `authentication_status` to SingleSignatures entity
Alenar a9ba1ff
Buffer signature if they're authenticated
Alenar c859a5a
Remove `multi_signer` dependency from buffered certifier service
Alenar c19f497
Skip (de)serialization of single signature `authentication_status`
Alenar 5d81f67
Make buffer integration test send authenticated signatures
Alenar ebdea24
Add `SingleSignatureAuthenticator` in aggregator
Alenar f51ac9a
Wire `SingleSignatureAuthenticator` in aggregator dependencies
Alenar 2d6e9eb
Make aggregator `register_signatures` route check signature authenticity
Alenar 4c32c7b
Aggregator `/register-signatures` return 404 when signature with sign…
Alenar eeb23cf
Remove `signed_message` from `SingleSignatures` entity
Alenar d06bb6e
refactor: rename `AsMessage` to `ToMessage`
Alenar ad4d1db
refactor+style: Implement changes asked in PR reviews
Alenar 90f7c20
style: naming & comments adjustements from pr reviews
Alenar f62785c
chore: bump crates & openapi versions
Alenar 5b578c7
docs: update CHANGELOG
Alenar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.