Skip to content

Conversation

@sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Sep 5, 2024

Content

Updating dependencies is described in the runbook docs/runbook/upgrade-repository-dependencies/README.md.
To avoid doing all these operations manually and limit the risk of error, we want to provide a script that does all these operations

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1901

@github-actions
Copy link

github-actions bot commented Sep 5, 2024

Test Results

    4 files  ±0     53 suites  ±0   9m 28s ⏱️ ±0s
1 247 tests ±0  1 247 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 458 runs  ±0  1 458 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 52c9a94. ± Comparison against base commit 6f9da0c.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel requested a review from Alenar September 5, 2024 16:12
@Alenar Alenar force-pushed the sfa/script_to_upgrade_dependencies branch from 9fcb705 to 52c9a94 Compare September 6, 2024 09:08
@Alenar Alenar temporarily deployed to testing-preview September 6, 2024 09:15 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet September 6, 2024 09:15 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review September 6, 2024 09:23
@sfauvel sfauvel merged commit 8690abe into main Sep 6, 2024
@sfauvel sfauvel deleted the sfa/script_to_upgrade_dependencies branch September 6, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants