Skip to content

Implement Cardano stake distribution in mithril-client library #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 7, 2024
Merged

Implement Cardano stake distribution in mithril-client library #1882

merged 8 commits into from
Aug 7, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Aug 6, 2024 •
edited
Loading

Content

This PR adds new functionalities to the mithril-client crate related to Cardano stake distribution. The library now supports the following features:

  • Retrieve a Cardano stake distribution by its hash.
  • Retrieve a Cardano stake distribution by its epoch.
  • Get a list of available Cardano stake distributions.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1842

@dlachaume dlachaume requested a review from jpraynaud August 6, 2024 13:34
@dlachaume dlachaume self-assigned this Aug 6, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 6, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 6, 2024 •
edited
Loading

Test Results

    4 files  ± 0     53 suites  ±0   9m 20s ⏱️ +5s
1 225 tests +10  1 225 ✅ +10  0 💤 ±0  0 ❌ ±0 
1 421 runs  +40  1 421 ✅ +40  0 💤 ±0  0 ❌ ±0 

Results for commit b333696. ± Comparison against base commit 62f71c6.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume force-pushed the dlachaume/1842/implement-cardano-stake-distribution-in-client branch from 72d8b24 to b8f26f4 Compare August 6, 2024 13:43
@dlachaume dlachaume temporarily deployed to testing-preview August 6, 2024 13:55 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 6, 2024 13:55 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1842/implement-cardano-stake-distribution-in-client branch from b8f26f4 to c224792 Compare August 6, 2024 15:39
jpraynaud
jpraynaud approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the dlachaume/1842/implement-cardano-stake-distribution-in-client branch from c224792 to d970670 Compare August 6, 2024 15:50
@dlachaume dlachaume temporarily deployed to testing-preview August 6, 2024 15:59 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 6, 2024 15:59 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1842/implement-cardano-stake-distribution-in-client branch from d970670 to 1bdeb08 Compare August 6, 2024 16:37
@dlachaume dlachaume force-pushed the dlachaume/1842/implement-cardano-stake-distribution-in-client branch from 1bdeb08 to b79a9ee Compare August 6, 2024 16:38
@dlachaume dlachaume temporarily deployed to testing-preview August 6, 2024 16:48 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 6, 2024 16:48 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1842/implement-cardano-stake-distribution-in-client branch from b79a9ee to b333696 Compare August 6, 2024 16:49
@dlachaume dlachaume temporarily deployed to testing-preview August 6, 2024 16:58 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 6, 2024 16:58 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit c9a1e5b into main Aug 7, 2024
@dlachaume dlachaume deleted the dlachaume/1842/implement-cardano-stake-distribution-in-client branch August 7, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Cardano Stake Distribution in client library

3 participants

@dlachaume @jpraynaud