Skip to content

fix: clippy warnings with Rust 1.80.0 #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix: clippy warnings with Rust 1.80.0 #1857

merged 2 commits into from
Jul 25, 2024

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 25, 2024

Content

This PR includes fixes to clippy warnings occurring following the release of Rust 1.80.0.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jul 25, 2024
@jpraynaud jpraynaud requested review from dlachaume and sfauvel July 25, 2024 13:52
sfauvel
sfauvel approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jul 25, 2024

Test Results

    4 files  ±0     52 suites  ±0   9m 6s ⏱️ -1s
1 157 tests ±0  1 157 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 323 runs  ±0  1 323 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 500a765. ± Comparison against base commit 3b6557b.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 25, 2024 14:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 25, 2024 14:07 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 303d8c4 into main Jul 25, 2024
@jpraynaud jpraynaud deleted the jpraynaud/fix-clippy-warnings-rust-1.80 branch July 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpraynaud @sfauvel @dlachaume