Skip to content

fix: Resource not Reset when given back to Pool #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix: Resource not Reset when given back to Pool #1848

merged 2 commits into from
Jul 23, 2024

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 22, 2024 •
edited
Loading

Content

This PR includes a fix to the ResourcePool to reset the resource given back even when it is done through the ResourcePoolItem wrapper.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jul 22, 2024
@github-actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   9m 4s ⏱️ +21s
1 144 tests +2  1 144 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 310 runs  +2  1 310 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 6627346. ± Comparison against base commit a2d3fe1.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 22, 2024 10:56 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 22, 2024 10:56 — with GitHub Actions Inactive
@jpraynaud jpraynaud requested review from dlachaume and sfauvel July 22, 2024 12:26
sfauvel
sfauvel approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a small remark

jpraynaud added 2 commits July 23, 2024 10:50
@jpraynaud
fix: resource is not systematically reset when given back to a pool
178b538 
The reset did not occur when the resource is given back directly without the wrapper.
@jpraynaud
chore: bump crate version
6627346 
- 'mithril-common' from '0.4.33' to '0.4.34'.
@jpraynaud jpraynaud force-pushed the jpraynaud/fix-resource-pool-reset branch from d21ffbf to 6627346 Compare July 23, 2024 08:50
@jpraynaud jpraynaud temporarily deployed to testing-preview July 23, 2024 08:57 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 23, 2024 08:57 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 9f8b589 into main Jul 23, 2024
@jpraynaud jpraynaud deleted the jpraynaud/fix-resource-pool-reset branch July 23, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpraynaud @sfauvel @dlachaume