Skip to content

Fix Signer make test command errors #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix Signer make test command errors #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25b20e7
Remove ownership on `MockServer` in `aggregator_client` test functions
dlachaume Jul 12, 2024
6eb2214
Update crate version
dlachaume Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mithril-signer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mithril-signer"
version = "0.2.161"
version = "0.2.162"
description = "A Mithril Signer"
authors = { workspace = true }
edition = { workspace = true }
Expand Down
18 changes: 9 additions & 9 deletions mithril-signer/src/aggregator_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,21 +492,21 @@ mod tests {
)
}

fn set_returning_412(server: MockServer) {
let _mock_412 = server.mock(|_, then| {
fn set_returning_412(server: &MockServer) {
server.mock(|_, then| {
then.status(412)
.header(MITHRIL_API_VERSION_HEADER, "0.0.999");
});
}

fn set_returning_500(server: MockServer) {
let _server_mock = server.mock(|_, then| {
fn set_returning_500(server: &MockServer) {
server.mock(|_, then| {
then.status(500).body("an error occurred");
});
}

fn set_unparsable_json(server: MockServer) {
let _server_mock = server.mock(|_, then| {
fn set_unparsable_json(server: &MockServer) {
server.mock(|_, then| {
then.status(200).body("this is not a json");
});
}
Expand All @@ -528,7 +528,7 @@ mod tests {
#[tokio::test]
async fn test_aggregator_features_ko_412() {
let (server, client) = setup_server_and_client();
set_returning_412(server);
set_returning_412(&server);

let error = client.retrieve_aggregator_features().await.unwrap_err();

Expand All @@ -538,7 +538,7 @@ mod tests {
#[tokio::test]
async fn test_aggregator_features_ko_500() {
let (server, client) = setup_server_and_client();
set_returning_500(server);
set_returning_500(&server);

let error = client.retrieve_aggregator_features().await.unwrap_err();

Expand All @@ -548,7 +548,7 @@ mod tests {
#[tokio::test]
async fn test_aggregator_features_ko_json_serialization() {
let (server, client) = setup_server_and_client();
set_unparsable_json(server);
set_unparsable_json(&server);

let error = client.retrieve_aggregator_features().await.unwrap_err();

Expand Down