Skip to content

Conversation

@jpraynaud
Copy link
Member

Content

This PR includes an ugprade of the dependencies of the repository:

  • Rust dependencies
  • Documentation website
  • mithril-client-wasm/www website
  • mithril-client-wasm/www-test website

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1810

@jpraynaud jpraynaud self-assigned this Jul 10, 2024
@github-actions
Copy link

github-actions bot commented Jul 10, 2024

Test Results

    4 files  ±0     52 suites  ±0   8m 55s ⏱️ +4s
1 145 tests ±0  1 145 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 311 runs  ±0  1 311 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0869a7c. ± Comparison against base commit 640ee4d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To upgrade mithril-client-wasm JS packages www and www-test, I'd suggest to run this command instead:
cd mithril-client-wasm && make upgrade-www-deps

Do we need to runnix flake update too?

Error message: 'Server cert key DER is valid; qed: InvalidCertificate(Other(OtherError(UnsupportedCriticalExtension)))'
Fixed by running: 'cargo update -p [email protected] --precise 0.23.10' and 'cargo update -p [email protected] --precise 0.102.4'
Issue followed by libp2p/rust-libp2p#5487
By running 'nix flake update' command.
@jpraynaud jpraynaud temporarily deployed to testing-preview July 10, 2024 12:55 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 10, 2024 12:55 — with GitHub Actions Inactive
@jpraynaud
Copy link
Member Author

To upgrade mithril-client-wasm JS packages www and www-test, I'd suggest to run this command instead: cd mithril-client-wasm && make upgrade-www-deps

I created this issue to document and standardize the dependencies upgrade process: #1813
The new run book will be the perfect place to put this information 🙂

Do we need to runnix flake update too?

I added the upgrade for nix 👍

@jpraynaud jpraynaud temporarily deployed to testing-preview July 10, 2024 13:18 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 10, 2024 13:18 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 6756b0f into main Jul 10, 2024
@jpraynaud jpraynaud deleted the 1810-upgrade-dependencies branch July 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants