Skip to content

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 8, 2024

Content

This PR includes a refactoring of the Cardano node configuration in the infrastructure:

  • It used to rely on the https://github.com/input-output-hk/cardano-configurations repository which is not well suited to handling edge case such as the co-existence of 8.9 and 8.12 as released version but running on different configurations.
  • Configuration files are now retrieved from the source website: https://book.play.dev.cardano.org/.
  • The new configuration supports the definition of patch or minor versions specific configurations which allows to now support the 8.12 configuration on the release-mainnet network.
  • Also the deployments are now triggered when the aggregator or signer configuration is modified (Cardano version and/or node specific configuration parameters).

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1787

@jpraynaud jpraynaud self-assigned this Jul 8, 2024
@jpraynaud jpraynaud requested review from Alenar, dlachaume and sfauvel July 8, 2024 13:14
@github-actions
Copy link

github-actions bot commented Jul 8, 2024

Test Results

    4 files  ±0     52 suites  ±0   8m 54s ⏱️ +8s
1 141 tests ±0  1 141 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 307 runs  ±0  1 307 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 297f7c6. ± Comparison against base commit 9625476.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1787-configuration-cardano-node branch from a9d056e to 297f7c6 Compare July 8, 2024 13:34
@jpraynaud jpraynaud temporarily deployed to testing-preview July 8, 2024 13:41 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 8, 2024 13:41 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit c9fab14 into main Jul 9, 2024
@jpraynaud jpraynaud deleted the jpraynaud/1787-configuration-cardano-node branch July 9, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants