Skip to content

Fix: Support Cardano 8.12 #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 4, 2024
Merged

Fix: Support Cardano 8.12 #1799

merged 4 commits into from
Jul 4, 2024

Conversation

@jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 4, 2024 •
edited
Loading

Content

This PR includes:

  • A new configuration for the Cardano nodes to avoid a manual fix to make the nodes start
  • The rollback of the sanchonet version to 8.11.0-pre following networking problems in 8.12.0-pre

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1787

@jpraynaud jpraynaud self-assigned this Jul 4, 2024
@jpraynaud jpraynaud requested review from Alenar, dlachaume and sfauvel July 4, 2024 10:03
@github-actions
Copy link

github-actions bot commented Jul 4, 2024

Test Results

    4 files  ±0     51 suites  ±0   8m 41s ⏱️ -12s
1 114 tests ±0  1 114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 262 runs  ±0  1 262 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2ac64b3. ± Comparison against base commit b87a4c2.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 4, 2024 10:09 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 4, 2024 10:09 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit f10e4eb into main Jul 4, 2024
@jpraynaud jpraynaud deleted the jpraynaud/1787-fix-support-cardano-8.12 branch July 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

+2 more reviewers

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jpraynaud jpraynaud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpraynaud @Alenar @sfauvel @dlachaume