-
Notifications
You must be signed in to change notification settings - Fork 52
Closed
Labels
refactoring 🛠️Code refactoring and enhancementsCode refactoring and enhancements
Description
Why
We want to have only one CardanoNetwork implementation in the repository when it is currently implemented in multiple crates.
What
Refactor the CardanoNetwork entity to be the unique and reusable implementation.
How
- Make the
CardanoNetworkaccessible from the client library - Remove the
TESTNET_MAGIC_IDconstant which is not used any more - Merge the
DevNetvariant into theTestNetvariant - Suppress the
--cardano-modeusage in the devnet and cli runner module - Provide bijective conversion from
ProtocolMagicIdtoCardanoNetwork -
Can we remove thefrom_codefunction and use the conversion fromProtocolMagicId? - Rename the
codefunction tomagic_id - Use this implementation in the snapshot converter automatic detection of the Cardano network in the client CLI.
- Convert the usage of
DevNetvariant in the aggregator databases if any?
Metadata
Metadata
Assignees
Labels
refactoring 🛠️Code refactoring and enhancementsCode refactoring and enhancements