Port integration tests to grpc 0.8 #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzabaluev
added
A-tests
dkijania
approved these changes
May 19, 2020
|
The test failures are blocked on stepancheg/grpc-rust#184. Suggesting a crash program of porting the tests to tonic. Interop testing on a dissimilar gRPC stack was nice, but it's becoming a drag. Also the API was never great and did not improve much in 0.8. The issues with having to nail down specific versions of protobuf (stepancheg/grpc-rust#172) and protoc-rust (stepancheg/grpc-rust#183) are not likely to go away, either. |
|
Migration to tonic is already on my long todo list. Maybe this problem will move it on top. My suggestion is to ignore test at this moment and I'll prioritize migration to tonic |
Bumps [grpc](https://github.com/stepancheg/grpc-rust) from 0.6.2 to 0.8.0. - [Release notes](https://github.com/stepancheg/grpc-rust/releases) - [Changelog](https://github.com/stepancheg/grpc-rust/blob/master/CHANGELOG.md) - [Commits](stepancheg/grpc-rust@v0.6.2...v0.8.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.