Fix error with specifying rev to builtins.fetchGit when creating cache#366
Merged
angerman merged 1 commit intoinput-output-hk:masterfrom Dec 13, 2019
Conversation
Collaborator
|
Needs more lisp! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #348 I added support to the cache machinery to be able to use
bulitins.fetchGitfor working with private git repositories.The cache got a new argument
rev(among others) that can be used for specifying a different branch to use (other thanmasterorHEAD).However, there was a logic error for specifying
rev. I missed parenthesis around the record I was constructing.This PR fixes this logic error.