Fix nix-prefetch-git to work from within the nix build#351
Closed
balsoft wants to merge 1 commit intoinput-output-hk:masterfrom
Closed
Fix nix-prefetch-git to work from within the nix build#351balsoft wants to merge 1 commit intoinput-output-hk:masterfrom
balsoft wants to merge 1 commit intoinput-output-hk:masterfrom
Conversation
Collaborator
|
I’d rather see this as a patch over nix-prefetch-git than an outright new script. That way staying current with upstream as well as making the changes explicit are given. |
Contributor
Author
|
Actually, this probably should be fixed in a different way. See https://gitlab.com/tezosagora/agora/commit/330ae03ed732b8843c94be3724dd4637178091b1 , where @yorickvP fixed this problem so that |
Collaborator
|
@balsoft so you are saying we should abandon this PR, in favour of one that generates? |
Contributor
Author
Collaborator
|
Closed in favour of #358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a patched nix-prefetch-git so that uncached dependencies can be downloaded using IFD (with
--no-sandbox, of course). Fixes #335