Fix using local stack snapshots#338
Merged
angerman merged 1 commit intoinput-output-hk:masterfrom Dec 4, 2019
Merged
Conversation
Contributor
Author
cool story |
69bd646 to
7c2c364
Compare
Contributor
Author
|
The problem was that |
Contributor
Author
|
Ok, got it, scratch these changes. The correct fix is to make |
7c2c364 to
d6008a4
Compare
Contributor
Author
|
So I removed the “fix” commit from this PR, but the test is still useful (merge it after bumping the version of |
48c6f32 to
d6008a4
Compare
angerman
approved these changes
Nov 29, 2019
Collaborator
angerman
left a comment
There was a problem hiding this comment.
awesome! A test case 🎉 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used to be part of #334. I added a test for this and made a bunch of little tweaks here and there to make sure that it actually works 🙄.
The newly added test now passes, but, for some reason, it produces the following warnings, I have no clue why:
cc @balsoft